adm1026 driver port for kernel 2.6.10-rc2 [RE-REVISED DRIVER]

Arjan van de Ven arjan at infradead.org
Mon Nov 22 22:00:42 CET 2004


> > this locking construct is rahter awkward; is it possible to refactor the
> > code such that you can down and up in the same function ?
> 
> Yes, at the cost of some minor code duplication or the introduction of
> another variable.  Is that preferable?  Is holding the lock across function
> calls a Bad Idea?

holding lock across function calls isn't, unlocking in another function than you take the lock is.
For one it makes auditing the code a lot harder.




More information about the lm-sensors mailing list