[PATCH 2.6] I2C: Fix macro calls in chip drivers

Greg KH greg at kroah.com
Wed Sep 8 21:38:17 CEST 2004


On Wed, Aug 25, 2004 at 10:44:08PM +0200, Jean Delvare wrote:
> Hi Greg,
> 
> I noticed that some I2C chip drivers (all written or reviewed by me, I
> feel ashamed to say) misuse macros. Passing function calls
> (simple_strtol in this case) to macros evaluating their argument up to 4
> times is certainly not wise and obviously performs poorly. It is not
> critical in that it happens only when writing to the chips (setting
> limits), which doesn't happen that often. However I'd say it's worth
> fixing.
> 
> Thus, the patch below fixes that, by moving the function calls outside
> of the macro calls.


Applied, thanks.

greg k-h



More information about the lm-sensors mailing list