[PATCH 2.6] I2C: Kill address ranges in non-sensors i2c chip drivers

Greg KH greg at kroah.com
Wed Apr 6 20:58:14 CEST 2005


On Sat, Apr 02, 2005 at 08:31:02PM +0200, Jean Delvare wrote:
> [Once again, this time *with* the signed-off-by line...]
> 
> Hi Greg,
> 
> Some months ago, you killed the address ranges mechanism from all
> sensors i2c chip drivers (both the module parameters and the in-code
> address lists). I think it was a very good move, as the ranges can
> easily be replaced by individual addresses, and this allowed for
> significant cleanups in the i2c core (let alone the impressive size
> shrink for all these drivers).
> 
> Unfortunately you did not do the same for non-sensors i2c chip drivers.
> These need the address ranges even less, so we could get rid of the
> ranges here as well for another significant i2c core cleanup. Here comes
> a patch which does just that. Since the process is exactly the same as
> what you did for the other drivers set already, I did not split this one
> in parts.
> 
> A documentation update is included.
> 
> The change saves 308 bytes in the i2c core, and an average 1382 bytes
> for chip drivers which use I2C_CLIENT_INSMOD, 126 bytes for those which
> do not.
> 
> This change is required if we want to merge the sensors and non-sensors
> i2c code (and we want to do this).
> 
> Please apply,
> thanks.

Applied, thanks.

greg k-h



More information about the lm-sensors mailing list