RFC PATCH sysfs names: fscher: remove revision

Jean Delvare khali at linux-fr.org
Wed Apr 27 18:55:09 CEST 2005


Hi Grant,

> fscher exposes chip revision to user-space, but does not use it 
> internally, this patch removes revision filename

I am in favor of this change, with two minor objections:

1* Maybe you could add an info printk saying "fscher: Found FSC Hermes
chip, revision %d", like the it87 driver does for example. That way,
people still get to know the revision of the chip if it should ever
matter.

2*
>  static void fscher_init_client(struct i2c_client *client)
>  {
> -	struct fscher_data *data = i2c_get_clientdata(client);
>  
> -	/* Read revision from chip */
> -	data->revision =  fscher_read_value(client, FSCHER_REG_REVISION);
>  }

This function can obviously go away altogether now. Empty static
functions are not that useful.

Thanks,
-- 
Jean Delvare



More information about the lm-sensors mailing list