[patch] i2c 2.9.1 compile fix

Thomas Jarosch thomas.jarosch at intra2net.com
Sat Apr 30 23:24:57 CEST 2005


> > attached is a patch to fix i2c-algo-bit.c compilation.
> > It was lacking the KERNEL_VERSION macro.
> >
> > Please CC: comments.
>
> Great catch. For some reason it wasn't blocking the compilation for me,
> nor anyone else I guess, or we would have heard of it before - but that
> was still bad.

Now comes the funky part: I compile my kernel with MODVERSIONS.
Only the compilation of the ".ver" file failed during the build process.
This results in mismatching module symbols for i2c-core and i2c-algo-bit 
afterwards, so I was unable to load the module and had to take a closer look.

> I opted for a different fix, dropping the conditional altogether. This
> branch of i2c is meant for Linux 2.4 only, so there's no point in
> keeping Linux 2.5+ compatibility code in there.

Nice.

Cheers,
Thomas



More information about the lm-sensors mailing list