Error messages on ignored values
khali at linux-fr.org
Fri Feb 4 20:37:38 CET 2005
> I'll apply your patch, thanks.
On second thought, I think that the patch could be improved a bit:
1* You hide SENSORS_ERR_PROC errors for all channels, but I guess only
some of them can actually be missing with the 2.6 driver?
2* You return the exact same error message for the two possible causes
of failure (sensors_get_label_and_valid failing and sensors_get_feature
failing). Now that you separated the "if" statements, it would be better
to have different error messages.
Care to send an updated patch?
More information about the lm-sensors