[PATCH][I2C] Marvell mv64xxx i2c driver

Mark A. Greer mgreer at mvista.com
Wed Feb 9 22:33:59 CET 2005


Bartlomiej Zolnierkiewicz wrote:

>Thanks, I see that you did global replacement of __devinit
>by __init and __devexit by __exit - it seems correct *only* if:
>- there can be only one i2c controller in the system
>- there can be only one host bridge in the system
>- i2c core calls ->probe only once during driver init
>  and ->remove only once during driver exit
>
>If all conditions are really true some comment about
>this in the code would still be be nice.
>

You're right.  The 'dev' is back except on the module_init/exit routines.

>While at it more silly, minor nitpicking ;)
>
>  
>
>>+static void
>>+mv64xxx_i2c_wait_for_completion(struct mv64xxx_i2c_data *drv_data)
>>+{
>>+       long    flags, time_left;
>>    
>>
>
>'flags' are of 'unsigned long' not 'long' type
>

Fixed.

>there is no need for explicit return in void functions
>

I can't find any definitive policy on this.  I kind of like the explicit 
return, I don't know why.  I've had others make the same comment, 
though, so I'll remove them since it obviously bothers people.

Attached is a replacement patch.

Thanks again, Bartlomiej.

Mark
--
Marvell makes a line of host bridge for PPC and MIPS systems.  On those 
bridges is an i2c controller.  This patch adds the driver for that i2c 
controller.

Please apply.

Depends on patch submitted by Jean Delvare: 
http://archives.andrew.net.au/lm-sensors/msg29405.html

Signed-off-by: Mark A. Greer <mgreer at mvista.com>
-- 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: i2c_9.patch
URL: <http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050209/02720f63/attachment.ksh>


More information about the lm-sensors mailing list