[RFC/PATCH] lost arbitration detection for PCF8584

Eric ebrower at usa.net
Sat Feb 19 20:47:24 CET 2005



------ Original Message ------
Received: Sat, 19 Feb 2005 01:43:12 AM PST
From: "Oleg I. Vdovikin" <vdovikin at jscc.ru>
To: Eric Brower <ebrower at usa.net>Cc: lm78 at stimpy.netroedge.com
Subject: Re: [RFC/PATCH] lost arbitration detection for PCF8584

> Hi,
> 
>   the patch is looks fine to me, except these lines:
> 
> > @@ -414,8 +452,8 @@
> >  
> >  static u32 pcf_func(struct i2c_adapter *adap)
> >  {
> > -       return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL | 
> > -              I2C_FUNC_10BIT_ADDR | I2C_FUNC_PROTOCOL_MANGLING; 
> > +       return I2C_FUNC_SMBUS_EMUL | I2C_FUNC_10BIT_ADDR | 
> > +              I2C_FUNC_PROTOCOL_MANGLING; 
> >  }
>   Why you've removed I2C_FUNC_I2C?

It was not on purpose-- I've been working between two BK trees and one
apparently was older than the other so the change propagated-- that section of
the patch can certainly be dropped.  My appologies for not trimming that bogus
section.

E








More information about the lm-sensors mailing list