two questions about w83792d.c for linux-2.4

Jean Delvare khali at linux-fr.org
Thu Feb 24 07:58:11 CET 2005


Hi Chunhao,

> > ...set the "in" file magnitude to 3 (which means divide by
> > 1000).
> 
> I want to add some comment here, since we use "3" as the magnitude
> of voltage now instead of the original "2", I think I should modify
> the program "sensors" 792 part(prog/sensors.chip.c), so that it can
> show the magnitude 3.
> 
> For Example: when we run "sensors"
> VCoreA:    +1.52 V  (min =  +1.40 V, max =  +1.60 V)
> Should be:
> VCoreA:    +1.524 V  (min =  +1.400 V, max =  +1.600 V)
> because the interface in0 in /proc is "1.400 1.600 1.524"
> 
> Do you agree with me?

Technically, you do not *need* to do it. I think we have several drivers
exporting more decimal places than "sensors" displays, because
additional places sometimes add little value and makes the output of
"sensors" a little harder to read.

Now, in the case of the w83792d driver, it is definitely a good idea to
display 3 decimal places for VCoreA and VCoreB, because these are low
value, high resolution inputs. For the other voltages it is less
important but probably still a good idea, except for in7 and in8 because
they don't have the extra accuracy bits. Same for limits, they don't
have the extra accuracy bits so I would not display 3 decimal places,
only 2. That being said you are relatiely free in your choices here and
if you really want to display 3 decimal places for all voltage values,
it's fine with me.

What *is* important however is that you use the same magnitude in
lib/chips.c than the driver uses (here 3 for the voltage inputs). If you
don't, sensors won't show the correct values.

Thanks,
-- 
Jean Delvare



More information about the lm-sensors mailing list