[lm-sensors] [PATCH 2.6] hwmon: kill cast abuses

Jean Delvare khali at linux-fr.org
Sun Jul 31 14:23:54 CEST 2005


Hi Greg, all,

Quoting myself:
> Some hardware monitoring drivers use needless casts to long.
> Especially, three Winbond drivers use many of them. Let's clean this
> up for the sake of code readability, if nothing else.
> 
> Signed-off-by: Jean Delvare <khali at linux-fr.org>
> 
>  drivers/hwmon/adm1026.c  |    2 +-
>  drivers/hwmon/it87.c     |    4 ++--
>  drivers/hwmon/lm85.c     |    4 ++--
>  drivers/hwmon/w83627hf.c |   29 ++++++++++++++---------------
>  drivers/hwmon/w83781d.c  |   29 ++++++++++++++---------------
>  drivers/hwmon/w83792d.c  |   14 +++++++-------
>  6 files changed, 40 insertions(+), 42 deletions(-)

Please don't apply that patch, it might not be as innocent as it looks.
I don't seem to understand the assembly code changes it causes. I'll
need to have an assembly expert take a look and explain it to me.

Thanks,
-- 
Jean Delvare




More information about the lm-sensors mailing list