[lm-sensors] Re: RFC PATCH I2C: w83781d: remove non-i2c sensor chips

Grant Coady grant_lkml at dodo.com.au
Fri Jun 3 23:29:56 CEST 2005


Hi Khali,
On Fri, 3 Jun 2005 21:46:32 +0200, Jean Delvare <khali at linux-fr.org> wrote:

>Hi Grant,
>
>> This patch removes non-i2c w83697hf, w83627thf sensor chips from the 
>> w83781d driver.  Compile tested.
>> 
>> Also remove references to those sensor chips in w83781d docs.
>
>Great, except for:
>
>> -	}
>> -	
>> +
That 'innocent blank line' had a <tab> in it, now I give back trailing 
whitespace, sigh . . .  _no_ whitespace mangling producing gratuitous 
noise, okay :o)
>
>Please avoid this "noise" change (same holds for all future patches, of
>course).
>
>> -	if (kind != w83697hf)
>> -		device_create_file_vid(new_client);
>> +	device_create_file_vid(new_client);
>>  
>> -	if (kind != w83697hf)
>> -		device_create_file_vrm(new_client);
>> +	device_create_file_vrm(new_client);
>
>You could additionally remove the blank line in between, as vid and vrm
>are tightly linked.
>
>All the rest is OK, good work.

So visible whitespace alignment okay, as above, but not 'noise' in top 
one.  Try to match surrounding whitespace style.  Subtle.

I'll make those changes, send new patch to Greg, copy list.

Thanks,
--Grant.





More information about the lm-sensors mailing list