[PATCH] fix Perl syntax errors in fancontrol.pl

Mark Studebaker mds at mds.gotdns.com
Wed May 4 22:50:22 CEST 2005


checked in to CVS
thanks
mds

Sergey Vlasov wrote:
> Hello!
> 
> The prog/pwm/fancontrol.pl script has some obvious syntax errors:
> 
> $ perl -cT fancontrol.pl 
> "my" variable $file masks earlier declaration in same scope at fancontrol.pl line 165.
> "my" variable $file masks earlier declaration in same scope at fancontrol.pl line 167.
> "my" variable $file masks earlier declaration in same statement at fancontrol.pl line 167.
> "my" variable $file masks earlier declaration in same scope at fancontrol.pl line 168.
> "our" variable $interval masks earlier declaration in same scope at fancontrol.pl line 172.
> "my" variable $fcvcount masks earlier declaration in same scope at fancontrol.pl line 193.
> syntax error at fancontrol.pl line 162, near "$)
> sub loadconfig($)
> "
> Can't use global $! in "my" at fancontrol.pl line 168, near "$file: $!"
> syntax error at fancontrol.pl line 214, near "}"
> fancontrol.pl had compilation errors.
> 
> Looks like this is caused by some strange lines before "sub ..."
> declarations, which apparently have been added in the last update at
> 2004/06/23 (hmm, if these errors are still there, probably nobody uses
> this script).
> 
> The patch below is untested due to lack of hardware supporting PWM,
> but at least "perl -cwT fancontrol.pl" passes now.
> 
> --- lm_sensors/prog/pwm/fancontrol.pl.alt-fix-fancontrol	2004-06-23 22:34:24 +0400
> +++ lm_sensors/prog/pwm/fancontrol.pl	2004-10-10 22:19:13 +0400
> @@ -157,7 +157,6 @@ while(1)
>  1;
>  
>  ################################################################ 
> -loadconfig($)
>  sub loadconfig($)
>  {
>     my $file = shift;
> @@ -215,7 +214,6 @@ $minstop);
>  
>  
>  ################################################################ 
> -pwmdisable($)
>  sub pwmdisable($)
>  {
>     my $p = shift;
> @@ -257,7 +255,6 @@ sub pwmdisable($)
>  
>  
>  ################################################################# 
> -pwmenable($)
>  sub pwmenable($)
>  {
>     my $p = shift;
> @@ -291,7 +288,6 @@ sub pwmenable($)
>  
>  
>  ################################################################ 
> -restorefans()
>  sub restorefans()
>  {
>     $SIG{TERM} = 'IGNORE';
> @@ -314,7 +310,6 @@ sub restorefans()
>  
>  
>  ############################################################ 
> -UpdateFanSpeeds()
>  sub UpdateFanSpeeds()
>  {
>     my $fcvcount = 0;
> 




More information about the lm-sensors mailing list