[lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks

Yani Ioannou yani.ioannou at gmail.com
Wed May 18 06:36:18 CEST 2005


Hi Jean,

> On 5/17/05, Jean Delvare <khali at linux-fr.org> wrote:
> > If you could come up with an additional demonstration patch for either
> > the lm90 driver or the it87 driver, I would happily give it a try. The
> > adm1026 has very few users AFAIK so it might not be the best choice to
> > find testers, although I agree that it was a convenient way to
> > demonstrate how drivers could benefit from the proposed change.

Here is a patch against it87, since it seems to have many more device
attributes than lm90. The size difference:

before:
Module                  Size  Used by
it87                   28832  0
after:
Module                  Size  Used by
it87                   22432  0

That isn't bad, but the code cleanup is worth it alone in my opinion.

Yani
-------------- next part --------------
 it87.c |  387 ++++++++++++++++++++++++++++++-----------------------------------
 1 files changed, 183 insertions(+), 204 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-linux-2.6.12-rc4-sysfsdyncallback-deviceattr-i2c-it87.diff
Type: text/x-patch
Size: 25290 bytes
Desc: not available
URL: <http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050518/3c74d163/attachment.bin>
-------------- next part --------------
_______________________________________________
lm-sensors mailing list
lm-sensors at lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


More information about the lm-sensors mailing list