[lm-sensors] Fix one bug of w83792d under linux-2.4

Huang0 at Winbond.com.tw Huang0 at Winbond.com.tw
Mon May 30 13:31:57 CEST 2005


Hi MDS, Rudolf, Jean

Quoting MDS
> I reviewed the datasheet about comparator/interrupt modes.
> Unfortunately, only the temps support comparator mode; voltages and 
> fans support only interrupt  mode (datasheet sections 7.7.5-7.7.7)

> My recommendation is that we set the temperature sensors to comparator
mode.
> The code at line 729 should put bits 7 and 6 of reg. 0x4C to 00
(comparator
> mode),
> which is what the comment says, but it sets it to 01 (2 times
interrupt mode).
> This is probably left over from whatever driver you copied from.
> So my recommendation is to set  the bits to 00.

I use the "comparator mode" to temperature sensors instead of the
original
method, would you please commit my modification for me? The attachment
is
the patch to lm_sensors-2.9.1.

I have tested it here on my two motherboards, it works well. The
modified
files are:
kernel/chips/w83792d.c
lib/chips.h
lib/chips.c
prog/sensors/chips.c


After you commit it for me, please just give me a response.


Thanks
Best Regards
Chunhao



===========================================================================================The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such  a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email irrelevant to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.
===========================================================================================If your computer is unable to decode Chinese font, please ignore the following message.It essentially repeats the statement in English given above.¥»«H¥ó¤º©Ò§tµØ¨¹¹q¤lªº°]²£©Ê¾÷±K©Ê¸ê°T, ¶È±ÂÅv­ìµo«H¤H«ü©w¤§¦¬«H¤H¨ú¾\\\\¤§¥Î. °²¨Ï±z¨Ã«D³Q«ü©w¤§¦¬«H¤H©Î¦]¥ô¦ó­ì¦]¦b¥¼¸g±ÂÅvªº±¡§Î¤§¤U¦¬¨ì¥»«H¥ó, ½Ð±z§iª¾­ìµo«H¤H¨Ã¥ß§Y±N«H¥ó±q¹q¸£»Pºô¸ô¦øªA¾¹¤¤¤©¥H®ø°£. ¹ï©ó±zªº¦X§@, §Ú­Ì¥ý¦¹­PÁÂ. ¯S¦¹´£¿ô, ¥ô¦ó¥¼¸g±ÂÅv¾Õ¦Û¨Ï¥ÎµØ¨¹¹q¤lªº¾÷±K¸ê°Tªº¦æ¬°¬O³QÄY®æ¸T¤îªº. «H¥ó»PµØ¨¹¹q¤lÀç·~µLÃö¤§¤º®e,¤£±oµø¬°µØ¨¹¹q¤l¤§¥ß³õ©Î·N¨£.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: w83792d_driver-1.0.4.patch
Type: application/octet-stream
Size: 8826 bytes
Desc: w83792d_driver-1.0.4.patch
URL: <http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050530/8630b5e9/attachment.obj>


More information about the lm-sensors mailing list