[lm-sensors] Re: i2c via686a.c: save at least 0.5k of space by long v[256] -> u16 v[256]

Denis Vlasenko vda at ilport.com.ua
Fri Sep 2 07:54:37 CEST 2005


On Thursday 01 September 2005 18:59, Greg KH wrote:
> On Thu, Sep 01, 2005 at 09:10:14AM +0300, Denis Vlasenko wrote:
> > Not tested, but it's rather obvious.
> 
> Except you forgot a "Signed-off-by:" line...
> 
> > --- linux-2.6.12.src/drivers/i2c/chips/via686a.c.orig	Sun Jun 19 16:10:10 2005
> > +++ linux-2.6.12.src/drivers/i2c/chips/via686a.c	Tue Aug 30 00:21:39 2005
> > @@ -205,7 +205,7 @@ static inline u8 FAN_TO_REG(long rpm, in
> >   but the function is very linear in the useful range (0-80 deg C), so 
> >   we'll just use linear interpolation for 10-bit readings.)  So, tempLUT 
> >   is the temp at via register values 0-255: */
> > -static const long tempLUT[] =
> > +static const int16_t tempLUT[] =
> 
> int16_t is not a proper kernel type.  Do you really mean s16 instead?

Ok. Please be informed that there are lots of intNN_t's in i2c dir tho...

> Care to redo this?

Signed-off-by: Denis Vlasenko <vda at ilport.com.ua>
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: via686a.patch
Type: text/x-diff
Size: 673 bytes
Desc: not available
URL: <http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050902/853e41de/attachment.bin>


More information about the lm-sensors mailing list