[lm-sensors] What about i2c_smbus_read_block_data() ?

Mark M. Hoffman mhoffman at lightlink.com
Thu Apr 5 04:42:18 CEST 2007


Hello:

* Hans-Jürgen Koch <hjk at linutronix.de> [2007-04-04 23:32:34 +0200]:
> Am Mittwoch, 4. April 2007 21:49 schrieb Hans-Jürgen Koch:
> > I'm working on a driver for LM93. I've got some code by Mark Hoffman, (c)2004. 
> > It doesn't compile on a recent kernel, because it heavily uses a function called
> > i2c_smbus_read_block_data(). Googling for that, I found this old mail in the
> > archives (October 2005):
> > 
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2005-October/013971.html
> > 
> > Jean, what do you say to that today? Can we have that function back in
> > mainline, or do I have to find another solution?
> > If you agree to add it, I could prepare a patch for it, if you don't have
> > a recent version handy.
> 
> Answering my own question: After looking at i2c-core.c et al., I find it quite
> obvious that this function should be added, if a driver needs it. 
> 
> I attached a patch that does this. Would that be acceptable? I can resend it
> when I have the LM93 patch ready.

I think if you put it in the same patchset with lm93.c, that will be fine.

Jean: I can do the initial review of this one for you when it's ready.

Regards,

-- 
Mark M. Hoffman
mhoffman at lightlink.com





More information about the lm-sensors mailing list