[lm-sensors] [PATCH 3/3] sensors3: Optimize command line handling

Jean Delvare khali at linux-fr.org
Mon Aug 27 10:28:35 CEST 2007


On Sat, 25 Aug 2007 19:23:42 +0200, Hans de Goede wrote:
> Jean Delvare wrote:
> > Thanks to the new prototype of sensors_get_detected_chips, we no
> > longer need to build an array from the chip names passed on the
> > command line. Instead, we can process them one after the other
> > directly. This saves some memory and allows for minor code cleanups.
> > 
> Looks good to me,

Thanks. All 3 patches applied now. I also made a big cleanup to
"sensors", mainly to better understand what exactly it needs from
libsensors, in the hope it'll help me in the last part of the API
review: sensors_get_all_features() and all the underlying features
gathering, designation and storage code. I'll work on this as time
permits during the week, and hopefully I can send a proposal for
discussion at the end of the week.

-- 
Jean Delvare



More information about the lm-sensors mailing list