[lm-sensors] [PATCH] Add LM93 support

[Mark M. Hoffman]

Hi Hans:

* Hans-Jürgen Koch <hjk at linutronix.de> [2007-07-05 17:58:29 +0200]:
> Am Donnerstag 05 Juli 2007 15:37 schrieb Mark M. Hoffman:
> 
> > > 
> > > 1.) I replaced pwmN_override with pwmN_enable.
> > 
> > 1825         case 0:
> > 1826                 ctl2 |= 0x01; /* enable manual override */
> > 1827                 ctl2 &= 0x0F; /* set PWM to zero */
> > 1828                 break;
> > 
> > No... the value 0 must turn the fan full-on, not off.  Sorry if I was not
> > clear about that in my review comments.
> > 
> > See also: Documentation/hwmon/sysfs_interface.
> 
> Quote from there:
> 
> pwm[1-*]_enable
> 		Switch PWM on and off.
> 		Not always present even if pwmN is.
> 		0: turn off
> 		1: turn on in manual mode
> 		2+: turn on in automatic mode
> 
> But checking my max6650 sources, I find that there we also said that
> 0 means "always on". Very confusing.
> 
> OK, I changed the patch, see below. 
> 
> And I'll send a patch to make Documentation/hwmon/sysfs-interface
> clearer. This is the second time it fools me.

Heh, notice the most recent patch in my testing tree...
http://lm-sensors.org/kernel?p=kernel/mhoffman/hwmon-2.6.git;a=shortlog;h=testing

I meant for you to check the docs in *my* tree, haha.  Sorry 'bout that.

I'll apply your lm93 patch this evening.

Regards,

-- 
Mark M. Hoffman
mhoffman at lightlink.com