[lm-sensors] [PATCH] Add f75375s driver

[Voipio Riku]

Hi Christian,

Thanks for your time reviewing and testing the driver.

> I tested the new version of the driver. Maybe i found one small bug.
> Should it be in function 'show_in_min':
> "return sprintf(buf, "%d\n", VOLT_FROM_REG(data->in_min[nr]));"
> instead of
> "return sprintf(buf, "%d\n", VOLT_FROM_REG(data->in_max[nr]));"?

Thanks, fixed.

> Another problem is still the value of tempX_max_hyst, the value is always
> zero. If i read sysfs direct i get following output:
> root at pc:/sys/devices/pci0000:00/0000:00:01.1/i2c-2/2-002d# cat
> temp1_max_hyst
> 0
> root at pc:/sys/devices/pci0000:00/0000:00:01.1/i2c-2/2-002d# cat
> temp2_max_hyst
> 0

What value are you setting it to?

thecus-1:/sys/devices/platform/IOP3xx-I2C.0/i2c-0/0-002e# cat temp1_max_hyst
55000
thecus-1:/sys/devices/platform/IOP3xx-I2C.0/i2c-0/0-002e# echo 55 >
temp1_max_hyst
thecus-1:/sys/devices/platform/IOP3xx-I2C.0/i2c-0/0-002e# cat temp1_max_hyst
0
ALL6500:/sys/devices/platform/IOP3xx-I2C.0/i2c-0/0-002e# echo 61000 >
temp1_max_hyst
ALL6500:/sys/devices/platform/IOP3xx-I2C.0/i2c-0/0-002e# cat temp1_max_hyst
61000

So it appears to work as expected. According to sysfs-interface temp*
should report and accept millidegrees or millivolts. We are outputting
millidegrees.

> I'm using kernel version 2.6.17-10, is that a problem? I use the driver
> for the f75373 chip.

Older kernel should not be a problem. I only have a f75375, but the
datasheets for hysteris parts are identical.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-f75375s-driver.patch
Type: text/x-diff
Size: 23274 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20070706/38f428e1/attachment-0001.bin