[lm-sensors] Better generic print fault handling

Jean Delvare khali at linux-fr.org
Sat Jul 7 21:04:09 CEST 2007


On Sat, 07 Jul 2007 18:38:03 +0200, Hans de Goede wrote:
> Jean Delvare wrote:
> > I guess that the main problem here is that we have an artificial split
> > of temp_print_info() outside of the generic temperature printing
> > function, while we shouldn't. This explains in part why the this
> > generic temperature printing function doesn't look quite good.
> 
> Hmm, I don't think putting all the temp_print_info() stuff into the function 
> will make it better, maybe it will, but I don't know if a function becomes tom 
> large splitting of small sub functions can be a good idea.

Agreed. But the number of arguments we are passing to temp_print_info()
right now clearly shows that something is wrong. Having everything in
the same file will make it easier to decide how to best split the code
between functions.

-- 
Jean Delvare



More information about the lm-sensors mailing list