[lm-sensors] hwmon/f75375s.c: buggy if()

Christian Emmerich christian_emmerich at yahoo.de
Thu Nov 1 12:27:53 CET 2007


Hi

 > Hi:
> 
> * Riku Voipio  [2007-10-26 14:14:23 +0300]:
> > On Fri, Oct 26, 2007 at 10:36:47AM +0200, Jean Delvare wrote:
> > > Patch looks correct, however it doesn't apply on top of Mark's tree. I
> > > was able to get it to apply by reverting "(f75375s) fix pwm mode
> > > setting" first, but then the build fails. Presumably the other f75375s
> > > patches interact badly. Can you please respin this patch on top of
> > > Mark's tree (i.e. on top the the 4 other f75375s patches you sent since
> > > the -rc1 merge)? Thanks.
> > 
> > The surrounding code had wandered to another function, so it's suprising
> > it applied at all. Here's respin.
> > 
> > -- 
> > "rm -rf" only sounds scary if you don't have backups
> 
> > >From 4de69e3ab5b5833cddb503f0dcb2a3ccc2d5b328 Mon Sep 17 00:00:00 > 2001
> > From: Riku Voipio 
> > Date: Fri, 26 Oct 2007 13:53:50 +0300
> > Subject: [PATCH] hwmon (f75375s) fix buggy if() properly
> > 
> >  Fix value check in set_pwm_mode(). Instead of checking for
> >  chip variant there, make pwmX_mode sysfs nodes only writable
> >  on f75375 variant.
> > 
> > Signed-off-by: Riku Voipio 
> > ---
> >  drivers/hwmon/f75375s.c |   19 ++++++++++++++++---
> >  1 files changed, 16 insertions(+), 3 deletions(-)
> > 
> 
> Applied to hwmon-2.6.git/testing, thanks.
> 
> -- 
> Mark M. Hoffman
> mhoffman at lightlink.com

Don't know if necessary, but i tested the driver using kernel 2.6.22-14, driver from kernel/mhoffman/hwmon-2.6.git - testing (28 Oct) and sensors version 3.0.0-rc3 with libsensors version 3.0.0-rc3. 

Fan-Speed, temperatures and voltage is displayed correctly. I can also change the fan speed without problem.
The only modification i made in lm-sensors, setting the value of driver to "f75375s" in prog/detect/sensors-detect for "Fintek F75373S/SG".

best regards
christian.
       
---------------------------------
Ihr erstes Fernweh? Wo gibt es den schönsten Strand. 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20071101/eeacb59d/attachment.html>


More information about the lm-sensors mailing list