[lm-sensors] hwmon/f75375s.c: buggy if()
Adrian Bunk
bunk at kernel.org
Wed Oct 17 21:54:39 CEST 2007
drivers/hwmon/f75375s.c contains the following code:
<-- snip -->
...
static ssize_t set_pwm_mode(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
...
if (val != 0 || val != 1 || data->kind == f75373)
return -EINVAL;
...
<-- snip -->
I'm not sure what exactly was intended, but it was for sure not intended
to always return -EINVAL...
Spotted by the Coverity checker.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
More information about the lm-sensors
mailing list