[lm-sensors] [PATCH 7/7] libsensors4: Don't store scaling factors

Jean Delvare khali at linux-fr.org
Tue Sep 4 10:35:25 CEST 2007


Hi Hans,

On Mon, 03 Sep 2007 19:53:05 +0200, Hans de Goede wrote:
> Jean Delvare wrote:
> > Note that the structures sensors_chip_feature and sensors_feature_data
> > are now exactly the same, so we could use one structure everywhere.
> > The only advantage to have two structures is that sensors_feature_data
> > is part of the API, while sensors_chip_feature is not, so if we
> > ever need to add internal attributes, for example to improve performance,
> > having an internal structure can be helpful. Question is, will we
> > actually ever need this? Opinion anyone?
> 
> I think it would be better to make them one and the same structure then, to 
> avoid confusion.

I tend to agree, however I will wait to be done with the API review and
changes before doing it, just in case.

Thanks for the reviews!

-- 
Jean Delvare



More information about the lm-sensors mailing list