[lm-sensors] [patch lm-sensors 2.10.4] i2cdetect mislabels PEC
David Brownell
david-b at pacbell.net
Wed Sep 19 00:45:36 CEST 2007
> > - .name = "SMBus PEC" },
> > + .name = "SMBus PEC in Hardware" },
>
> I agree that the current situation is confusing, I had noticed this
> already when reworking the PEC support in 2.6.15, but postponed fixing
> it.
>
> However, I don't think that what you proposed is the proper fix. We
> don't care whether PEC is implemented in hardware or software. What
> really matters is whether it is implemented at all, or not. So I'd
> rather rename I2C_FUNC_SMBUS_HWPEC_CALC to I2C_FUNC_SMBUS_PEC, and have
> i2c-algo-bit and other drivers declare that they support it. What do
> you think?
How about just not exposing that capability from i2cdetect at all?
There's a software implementation that's always available. Whether
that's used, or a (presumably accelerated) hardware one is used is
purely an implementation issue, not an interface issue that a driver
would have any reason to care about.
- Dave
More information about the lm-sensors
mailing list