[lm-sensors] [PATCH] hwmon: normal_i2c arrays should be const
Jean Delvare
khali at linux-fr.org
Mon Feb 18 10:50:23 CET 2008
Hi Mark,
On Sun, 17 Feb 2008 22:34:59 -0500, Mark M. Hoffman wrote:
> commit 556782f2a261fe87d3aa820d24116660b16f3192
> Author: Mark M. Hoffman <mhoffman at lightlink.com>
> Date: Sun Feb 17 22:28:03 2008 -0500
>
> hwmon: normal_i2c arrays should be const
>
> Signed-off-by: Mark M. Hoffman <mhoffman at lightlink.com>
>
Looks good to me from a functional point of view.
Acked-by: Jean Delvare <khali at linux-fr.org>
Note though that checkpatch spits the following warnings, which you may
want to fix:
WARNING: line over 80 characters
#108: FILE: drivers/hwmon/adm1021.c:35:
+ 0x4c, 0x4d, 0x4e, I2C_CLIENT_END };
WARNING: line over 80 characters
#420: FILE: drivers/hwmon/lm83.c:52:
+ 0x4c, 0x4d, 0x4e, I2C_CLIENT_END };
WARNING: line over 80 characters
#463: FILE: drivers/hwmon/lm90.c:105:
+ 0x4c, 0x4d, 0x4e, I2C_CLIENT_END };
WARNING: line over 80 characters
#508: FILE: drivers/hwmon/max1619.c:41:
+ 0x4c, 0x4d, 0x4e, I2C_CLIENT_END };
total: 0 errors, 4 warnings, 353 lines checked
--
Jean Delvare
More information about the lm-sensors
mailing list