[lm-sensors] [PATCH] Update: Add driver for AD7414 i2c temperature sensor

Jean Delvare khali at linux-fr.org
Tue Feb 19 20:07:19 CET 2008


On Tue, 19 Feb 2008 13:45:11 -0500, Sean MacLennan wrote:
> Jean Delvare wrote:
> >
> >> +	/* Register values */
> >> +	u16			temp_input;
> >> +	u8			temp_max;
> >> +	u8			temp_min;
> >>     
> >
> > Temperature values can be negative, so these should be s16 and s8
> > respectively.
> >
> >   
> I think these are fine as is. They are the raw values back from the chip 
> and are always passed through  AD7414_TEMP_FROM_REG.

temp_input is passed through AD7414_TEMP_FROM_REG(); temp_max and
temp_min aren't. So, the driver would fail to report negative limits
properly.

> Good catch on the simple_strtoul. I only tested positive values since 
> the taco will only be dealing in positive values.

-- 
Jean Delvare




More information about the lm-sensors mailing list