[lm-sensors] [PATCH 04/10] hwmon: (lm85) Don't write back cached values

Mark M. Hoffman mhoffman at lightlink.com
Wed Jun 25 15:20:37 CEST 2008


Hi Jean:

* Jean Delvare <khali at linux-fr.org> [2008-04-12 19:56:35 +0200]:
> In set_pwm_auto_pwm_minctl, we write cached register bits back to the
> chip. This is a bad idea as we have no guarantee that the cache is
> up-to-date. Better read a fresh register value from the chip, it's
> safer and in fact it is also more simple.
> 
> Signed-off-by: Jean Delvare <khali at linux-fr.org>
> ---
>  drivers/hwmon/lm85.c |   15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)

Applied to hwmon-2.6.git/testing, thanks.

-- 
Mark M. Hoffman
mhoffman at lightlink.com




More information about the lm-sensors mailing list