[lm-sensors] [PATCH 06/10] hwmon: (lm85) Simplify device initialization function

Mark M. Hoffman mhoffman at lightlink.com
Wed Jun 25 15:22:38 CEST 2008


Hi Jean:

* Jean Delvare <khali at linux-fr.org> [2008-04-12 20:00:18 +0200]:
> Clean up and simplify the device initialization function:
> * Degrade error messages to warnings - what they really are.
> * Stop warning about VxI mode, we don't really care.
> * Drop comment about lack of limit initialization - that's the standard
>   way, all hardware monitoring drivers do that.
> * Only read the configuration register once.
> * Only write back to the configuration register if needed.
> * Don't attempt to clear the lock bit, it locks itself to 1.
> * Move the function to before it's called, so that we no longer need to
>   forware declare it.
> 
> Signed-off-by: Jean Delvare <khali at linux-fr.org>
> ---
>  drivers/hwmon/lm85.c |   61 ++++++++++++++------------------------------------
>  1 file changed, 18 insertions(+), 43 deletions(-)

Applied[1] to hwmon-2.6.git/testing, thanks.

[1] http://jdelvare.pck.nerim.net/sensors/lm85/hwmon-lm85-06-cleanup-init-function.patch

-- 
Mark M. Hoffman
mhoffman at lightlink.com




More information about the lm-sensors mailing list