[lm-sensors] [patch 1/1] hwmon: add 0x8c id for smsc47b397 driver

Mark M. Hoffman mhoffman at lightlink.com
Sun Mar 2 20:48:03 CET 2008


Hi Matt:

* Matt Roberds <mattroberds at cox.net> [2008-02-29 17:58:26 -0600]:
> On Fri, 29 Feb 2008, Craig Kelley wrote:
> > +       case 0x85:
> > +       case 0x8c:
> > +               name = "SCH5317";
> > +               break;
> 
> Minor style thing: would
> 
>         case 0x85:
>                 /* fall through */
>         case 0x8c:
>                 name = "SCH5317";
>                 break;
> 
> be clearer?

Yes, but only if there were some code between the two cases.  As
written, I think it's clear enough; it's a pretty standard usage.

Thanks & regards,

-- 
Mark M. Hoffman
mhoffman at lightlink.com




More information about the lm-sensors mailing list