[lm-sensors] [RFC/PATCH] hwmon: fix common race conditions, batch 1, v2
Darrick J. Wong
djwong at us.ibm.com
Sat Mar 22 00:59:01 CET 2008
On Thu, Mar 20, 2008 at 09:32:38AM -0400, Mark M. Hoffman wrote:
> Hi all:
>
> adm1026.c | 22 ++++++++++++++--------
> adm1029.c | 30 +++++++++++++++++++-----------
> adm1031.c | 20 +++++++++++++++-----
> adm9240.c | 20 ++++++++++++++------
> adt7470.c | 40 ++++++++++++++++++++++++----------------
> adt7473.c | 54 +++++++++++++++++++++++++++++++-----------------------
> asb100.c | 16 ++++++++++++----
> 7 files changed, 129 insertions(+), 73 deletions(-)
>
> commit 3c798b55145f42725c54d64ac7d69062a5d62bad
> Author: Mark M. Hoffman <mhoffman at lightlink.com>
> Date: Mon Mar 3 23:35:52 2008 -0500
>
> hwmon: fix common race conditions, batch 1
>
> Most hwmon drivers have one or more race conditions that could cause the driver
> to display incorrect data; in the absolute worst case, these races could allow
> divide-by-zero/OOPS. The most common of these involves a race between setting
> a fan divider and displaying the fan data (RPMs). This patch fixes these race
> conditions by taking the update lock (or equivalent) as necessary.
>
> Signed-off-by: Mark M. Hoffman <mhoffman at lightlink.com>
The adt7470/7473 bits compile and survive simple testing, so
Acked-by: Darrick J. Wong <djwong at us.ibm.com>
--D
More information about the lm-sensors
mailing list