[lm-sensors] [resend] [PATCH v2] ibmaem: New driver for power/energy meters in IBM System X hardware

Andrew Morton akpm at linux-foundation.org
Wed May 7 02:36:07 CEST 2008


On Tue, 6 May 2008 15:38:13 -0700 "Darrick J. Wong" <djwong at us.ibm.com> wrote:

> [resend due to truncation]
> Refactor the registration function to shrink the macros.  Let me know if
> more aggressive de-macroing is desirable.
> ---
> New driver for power meters in IBM System X hardware, with a few
> cleanups suggested by Anthony Liguori.
> 
> ...
>
> +	int temp = simple_strtol(buf, NULL, 10); \

A checkpatch version which you might not have says

WARNING: consider using strict_strtol in preference to simple_strtol
#1015: FILE: drivers/hwmon/ibmaem.c:918:
+       int temp = simple_strtol(buf, NULL, 10); \

total: 0 errors, 1 warnings, 1221 lines checked

because the code as you have it will accept input of the form "12foo". 
strict_strtol() will error on that.

afacit the calling code would perhaps need a little changing to handle
such errors appropriately.



More information about the lm-sensors mailing list