[lm-sensors] [PATCH] Allow it87.c to handle IT8720

Frank Myhr fmyhr at fhmtech.com
Tue Oct 7 15:55:29 CEST 2008


Hi Jean-Marc,

Your patch looks good to me with a few niggles:


> To:
> LKML <linux-kernel at vger.kernel.org>, "LM Sensors"
> <lm-sensors at lm-sensors.org>

I don't know if it's necessary/recommended to submit directly to LKML in
addition to the lm-sensors list. (Maybe somebody else can comment on that.)


> The goal of this patch is to allow it87.c to handle IT8720 chipset
> like IT8718 in order to retreive voltage, temperatures and fans speed
> from sensors tools.
> 
> JMS
> 
> Patch also attached.

Good description but the "Patch also attached" is superfluous; your
[PATCH] subject line already says that. I believe these comments are
copied verbatim into the kernel git changelog, so it's important to keep
them succinct.

More importantly, you need to sign your patch with:

Signed-off-by: [your real name] [your email address]
---


> --- linux-2.6.27-rc8/drivers/hwmon/it87.c.orig  2008-10-02
> 09:04:44.000000000 -0400
> +++ linux-2.6.27-rc8/drivers/hwmon/it87.c       2008-10-06
> 13:27:08.000000000 -0400

Please make sure your mailer is not wrapping lines, it looks here like
it is.


Regards,
-Frank




More information about the lm-sensors mailing list