[lm-sensors] [PATCH 08/12] i5k_amb: Load automatically on all 5000/5400 chipsets

Darrick J. Wong djwong at us.ibm.com
Wed Oct 8 20:19:42 CEST 2008


On Wed, Oct 08, 2008 at 01:13:02PM +0200, Jean Delvare wrote:

> > +MODULE_ALIAS("pci:v00008086d000025F0sv*sd*bc*sc*i*");
> > +MODULE_ALIAS("pci:v00008086d00004030sv*sd*bc*sc*i*");
> 
> This looks wrong to me. If these PCI devices provide the feature this
> driver supports, then why is this a platform driver and not a PCI
> driver? You would get the right module aliases for free.

The AMB registers live at an arbitrary location in memory.  That
location is given in those PCI devices' config data, but the memory
address is not part of the device's memory.  The driver only attaches to
the PCI device long enough to read the location, and then it doesn't
need PCI or the device anymore.

--D




More information about the lm-sensors mailing list