[lm-sensors] [PATCH 0/5] sensord: Cleanup of the sensors deamon
andre.prendel at gmx.de
Sun Oct 4 21:07:09 CEST 2009
On Sat, Oct 03, 2009 at 10:35:25AM +0200, Jean Delvare wrote:
> On Tue, 16 Jun 2009 13:54:08 +0200, Jean Delvare wrote:
> > On Mon, 15 Jun 2009 09:45:46 +0200, Andre Prendel wrote:
> > > Hi Jean,
> > >
> > > here is another patch series cleaning up the sensors deamon.
> > >
> > > Some patches fixing some coding style issues, breaking long lines and
> > > making code more readable by the refactoring of big functions.
> > >
> > > Another one removes some needless casts and there is a patch
> > > converting the HTML code (CGI script) generated by sensord to lower
> > > case. So we're closer to XHTML. Unfortunately the output of rrdcgi
> > > isn't very strict.
> > >
> > > With this series I've finished the cleanup caused by the coding style
> > > conversion. During the work I saw some things to fix, so I will go on
> > > hacking the deamon. Now I hope the code is more readable and the
> > > maintenance and development should be easier. BTW I don't like some
> > > details of the implementation (see notes in patch 4/5). Some stuff
> > > looks needless. Further I would like it if the deamon would be closer
> > > to the sensors console tool. This would ease maintenance too. So you
> > > see what I'm going to do in the future.
> > Very nice. Thanks a lot for working on this, this was very needed.
> > > This here is post 3.1.1 material. Maybe we could make a stable branch
> > > 3.1.1? Otherwise we wait with the commits until 3.1.1 is released.
> > Let's just wait until 3.1.1 is released, it is less than 1 week away
> > now and nobody reviewed your patches yet anyway. I don't think it makes
> > much sense to create branches for 1-week SVN freeze periods. And
> > anyway, during these periods, we should all be testing the code rather
> > that developing new stuff ;)
> Andre, any news from these sensord patches? We spent quite some time on
> them, and they looked promising, it would be a pity if they are finally
no news so far :( To much other work since I changed the employer and
maybe I've been a bit lazy lately :)
Ok, I will reserve some time next week to revise the patches.
BTW I did some work on the DMI configuration topic a few month ago. I
don't forgot this one. But it's far from being ready. So far there's
just a bash script for fetching the configs from lm-sensors.org and
another one looking for DMI data and suitable config and copy this
one. Is it worth to post this prototype to have something to discuss
or should I better finish the work? I think I will post it :)
> Jean Delvare
More information about the lm-sensors