[lm-sensors] [PATCH] ltc4215/ltc4245: Discard obsolete detect methods

Ira W. Snyder iws at ovro.caltech.edu
Wed Oct 7 17:18:48 CEST 2009


On Sun, Sep 20, 2009 at 03:16:27PM +0200, Jean Delvare wrote:
> There is no point in implementing a detect callback for the LTC4215
> and LTC4245, as these devices can't be detected. It was there solely
> to handle "force" module parameters to instantiate devices, but now
> we have a better sysfs interface that can do the same.
> 
> So we can get rid of the ugly module parameters and the detect
> callbacks. This shrinks the binary module sizes by 36% and 46%,
> respectively.
> 
> Signed-off-by: Jean Delvare <khali at linux-fr.org>
> Cc: Ira W. Snyder <iws at ovro.caltech.edu>
> ---
> Ira, can you please test and confirm it works OK for you?
> 

I've finally gotten around to testing this. I applied it to 2.6.31.2.
Testing shows no problems at all. The devices are both automatically
bound by the OF device tree, just like before.

You've got my ACK.

Ira




More information about the lm-sensors mailing list