[lm-sensors] [PATCH] hwmon: (adt7462) Wrong ADT7462_VOLT_COUNT

Jean Delvare khali at linux-fr.org
Fri Jan 29 14:46:52 CET 2010


From: Ray Copeland <ray.copeland at aprius.com>
Subject: hwmon: (adt7462) Wrong ADT7462_VOLT_COUNT

The #define ADT7462_VOLT_COUNT is wrong, it should be 13 not 12. All the 
for loops that use this as a limit count are of the typical form, "for 
(n = 0; n < ADT7462_VOLT_COUNT; n++)", so to loop through all voltages 
w/o missing the last one it is necessary for the count to be one greater 
than it is.  (Specifically, you will miss the +1.5V 3GPIO input with count 
= 12 vs. 13.)

Signed-off-by: Ray Copeland <ray.copeland at aprius.com>
Signed-off-by: Jean Delvare <khali at linux-fr.org>
Cc: "Darrick J. Wong" <djwong at us.ibm.com>
Cc: stable at kernel.org
---
 drivers/hwmon/adt7462.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.33-rc5.orig/drivers/hwmon/adt7462.c	2010-01-13 09:16:42.000000000 +0100
+++ linux-2.6.33-rc5/drivers/hwmon/adt7462.c	2010-01-29 14:31:31.000000000 +0100
@@ -179,7 +179,7 @@ static const unsigned short normal_i2c[]
  *
  * Some, but not all, of these voltages have low/high limits.
  */
-#define ADT7462_VOLT_COUNT	12
+#define ADT7462_VOLT_COUNT	13
 
 #define ADT7462_VENDOR		0x41
 #define ADT7462_DEVICE		0x62


-- 
Jean Delvare



More information about the lm-sensors mailing list