[lm-sensors] [PATCH] hwmon: (asc7621) Bug fixes

[Ken Milmore]

Jean et al,

Find patch attached; this should apply against Linus' 2.6 tree. The 
issues fixed here have all been discussed before on the lm_sensors list 
(see 07/2008 and 04/2010), so hopefully they are uncontroversial.

Having taken a brief look at the PWM control inteface in the driver, I 
can see there are a few rough edges there but it is probably too late to 
address them now.  In particular the pwm[1-3]_enable and 
pwm[1-3]_auto_channels settings tend to interpret "Fan control disabled" 
as "Fan off", which doesn't accord with the principle of least surprise, 
or with the sysfs-interface documentation.  IMHO "Fan full on" would 
have been a much safer default for these settings...

Kind regards,

Ken.


On 28/04/10 13:32, Jean Delvare wrote:
> On Wed, 17 Mar 2010 08:39:17 +0100, Jean Delvare wrote:
>> Hi Ken,
>>
>> On Sun, 07 Mar 2010 10:20:13 +0000, Ken Milmore wrote:
>>> I will try and get a patch together as soon as time permits.
>>
>> Do you have a patch by now?
>
> Ping Ken. Would be nice to have a patch ready soon so that it can make
> it into kernel 2.6.35.
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-hwmon-asc7621-Bug-fixes.patch
URL: <http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20100501/2c1d9b55/attachment.ksh>