[lm-sensors] [PATCH] hwmon: applesmc: Add temperature sensor labels to sysfs interface

Henrik Rydberg rydberg at euromail.se
Tue May 4 13:15:51 CEST 2010


Jean Delvare wrote:
[...]
>> @@ -1578,6 +1717,8 @@ static int __init applesmc_init(void)
>>  		}
>>  		ret = sysfs_create_file(&pdev->dev.kobj,
>>  						temperature_attributes[i]);
> 
> Missing error handling.
> 
>> +		ret = sysfs_create_file(&pdev->dev.kobj,
>> +						label_attributes[i]);
>>  		if (ret)
>>  			goto out_temperature;
>>  	}
>

Shoot, my bad review. Will send a new patch. While at it, the same function
seems to leak fan attribute groups. Want me to correct such issues (in another
patch)?

Henrik





More information about the lm-sensors mailing list