[lm-sensors] [PATCH] hwmon: Add sch5127 support to dme1737

[Jeff Rickman]

Hi Jean,

> Hi Jean,
>
>> Hi Juerg,
>>
>> On Tue, 13 Apr 2010 10:49:15 +0200, Jean Delvare wrote:
>>> On Fri, 9 Apr 2010 10:20:40 -0700, Juerg Haefliger wrote:
>>> > I don't understand your proposal. Could you elaborate?
>>>
>>> I propose that you don't change the value of force_id in the driver.
>>> This value can be set by the user and should be considered read-only by
>>> the driver itself. The resulting code might be slightly larger, but it
>>> is also more correct:
>>>
>>> Â  Â  Â  /* Skip chip detection if module is loaded with force_id
>>> parameter */
>>> Â  Â  Â  switch (force_id) {
>>> Â  Â  Â  case SCH5127_ID:
>>> Â  Â  Â  Â  Â  Â  Â  data->type = sch5127;
>>> Â  Â  Â  Â  Â  Â  Â  break;
>>> Â  Â  Â  case SCH3112_ID:
>>> Â  Â  Â  Â  Â  Â  Â  data->type = sch311x;
>>> Â  Â  Â  Â  Â  Â  Â  break;
>>> Â  Â  Â  default:
>>> Â  Â  Â  Â  Â  Â  Â  company = dme1737_read(data, DME1737_REG_COMPANY);
>>> Â  Â  Â  Â  Â  Â  Â  device = dme1737_read(data, DME1737_REG_DEVICE);
>>>
>>> Â  Â  Â  Â  Â  Â  Â  if ((company == DME1737_COMPANY_SMSC) &&
>>> Â  Â  Â  Â  Â  Â  Â  Â  Â  (device == SCH311X_DEVICE)) {
>>> Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  data->type = sch5127;
>>> Â  Â  Â  Â  Â  Â  Â  } else if ((company == DME1737_COMPANY_SMSC) &&
>>> Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â (device == SCH5127_DEVICE)) {
>>> Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  data->type = sch311x;
>>> Â  Â  Â  Â  Â  Â  Â  } else {
>>> Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  err = -ENODEV;
>>> Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  goto exit_kfree;
>>> Â  Â  Â  Â  Â  Â  Â  }
>>> Â  Â  Â  }
>>>
>>> Â  Â  Â  data->name = data->type == sch5127 ? "sch5127" : "sch311x";
>>
>> Any progress with this patch? Would be nice to finally have support for
>> the SCH5127 in kernel 2.6.35.
>
> I sent a revised patch yesterday that you should have in your inbox.
> Waiting for Jeff.
>
> ...juerg

I am building a test system for this experiment; I have all the hardware I
need. It will take a few days, possibly to get done this weekend. Hope to
provide feedback sometime next week. How does that fit into the schedule
for delivering code to include in kernel 2.6.35?

>
>>
>> Thanks,
>> --
>> Jean Delvare
>>