[lm-sensors] [PATCH] hwmon: LTC4261 Hardware monitoring driver

Jean Delvare khali at linux-fr.org
Mon Oct 4 08:59:54 CEST 2010


On Sun, 3 Oct 2010 18:18:07 -0700, Guenter Roeck wrote:
> Hi Ira,
> 
> On Sun, Oct 03, 2010 at 05:17:42PM -0400, Ira W. Snyder wrote:
> > > +MODULE_DEVICE_TABLE(i2c, ltc4261_id);
> > > +
> > > +/* This is the driver that will be inserted */
> > > +static struct i2c_driver ltc4261_driver = {
> > > +   .driver = {
> > > +              .name = "ltc4261",
> > > +              },
> > > +   .probe = ltc4261_probe,
> > > +   .remove = ltc4261_remove,
> > > +   .id_table = ltc4261_id,
> > > +};
> > > +
> > 
> > I'd align the equal signs, like the ltc4245 driver does. No strong
> > preference, though. Like this:
> > 
> > static struct i2c_driver ltc4261_driver = {
> >         .driver = {
> >                 .name   = "ltc4261",
> >         },
> >         .probe          = ltc4261_probe,
> >         .remove         = ltc4261_remove,
> >         .id_table       = ltc4261_id,
> > };
> > 
> The formatting is the result of Lindent, which doesn't seem to like
> the extra blanks. In questions like this - where much of it is
> personal preference - I prefer to go with the Lindent results.

FWIW, I've never used Lindent. I only consider it as a tool for
converting really ugly-formatted code to acceptably-formatted code, not
as the perfect formatting script.

-- 
Jean Delvare




More information about the lm-sensors mailing list