[lm-sensors] [PATCH v2 1/3] hwmon: (lm90) Introduce chip parameter structure

Guenter Roeck guenter.roeck at ericsson.com
Wed Oct 6 18:14:59 CEST 2010


On Wed, Oct 06, 2010 at 12:10:35PM -0400, Jean Delvare wrote:
> On Wed, 6 Oct 2010 08:30:21 -0700, Guenter Roeck wrote:
> > On Wed, Oct 06, 2010 at 11:09:30AM -0400, Jean Delvare wrote:
> > > On Wed, 6 Oct 2010 17:05:53 +0200, Jean Delvare wrote:
> > > > I like this change a lot, even though it makes the binary module a
> > > > little larger.
> > > 
> > > Err, scratch that, it doesn't. Not sure why I thought it did...
> > > 
> > At least it makes the source a bit larger.
> > 
> > One thought: Would it make sense to use initdata for the initialization code ?
> 
> Almost impossible for I2C device drivers, as you never know when
> probe() will be called. For example, lm90 could be built into the
> kernel, but the underlying i2c bus driver be loaded as a module...
> 
Good point.

Guenter




More information about the lm-sensors mailing list