[lm-sensors] [PATCH v2] lis3: Fix Oops with NULL platform data
jic23 at cam.ac.uk
Fri Sep 24 17:10:06 CEST 2010
On 09/24/10 15:30, Jean Delvare wrote:
> On Fri, 24 Sep 2010 16:14:26 +0200, Takashi Iwai wrote:
>> At Fri, 24 Sep 2010 06:58:02 -0700,
>> Guenter Roeck wrote:
>>> On Thu, Sep 23, 2010 at 01:58:33AM -0400, Takashi Iwai wrote:
>>>> The recent addition of threaded irq handler causes a NULL dereference
>>>> when used with hp_accel driver, which has NULL pdata.
>>>> Acked-by: Samu Onkalo <samu.p.onkalo at nokia.com>
>>>> Acked-by: Acked-by: Guenter Roeck <guenter.roeck at ericsson.com>
>>>> Cc: <stable at kernel.org>
>>>> Signed-off-by: Takashi Iwai <tiwai at suse.de>
>> Oh, does this driver belong to hwmon tree?
>> Jean told me that this isn't managed in hwmon, so I had an impression
>> that it's an orphan driver.
> Well, as long as the driver lives in drivers/hwmon and the hwmon
> subsystem is maintained, it seems fair to consider the driver
Technically hwmon is orphan (according to MAINTAINERS.) But that's not to
say that various people aren't looking after various parts of it and
I believe Andrew Morton is acting as maintainer of last resort.
> That being said, I indeed would like all non-hwmon drivers to go away
> from drivers/hwmon. Originally we were waiting for iio to settle first,
> but apparently this is taking forever.
More developers and code reviewers always welcome!
> The 4 drivers I would like to
> kick are: ams, hdaps, lis3lv02d and applesmc. They are primarily
> accelerometer device drivers. Not sure where to put them,
> drivers/accel(erometer), drivers/misc, drivers/misc/accel(erometer),
> drivers/input/accel(erometer)... Opinions welcome.
If the primary use is as an input device then talk to Dmitry. Some
accelerometers are being taken into input. There are some open questions
on naming etc currently being debated so anyone interested should get
involved in those asap.
More information about the lm-sensors