[lm-sensors] x86/hwmon: fix module init for hotplug-but-no-device-found case

Guenter Roeck guenter.roeck at ericsson.com
Fri Sep 24 20:50:08 CEST 2010


On Mon, Sep 13, 2010 at 10:05:51AM -0000, Jan Beulich wrote:
> In commit 0dca94baeab4a1a514841b0a4c8e3a51dfb4d5ae the call to
> platform_driver_unregister() was made conditional upon !HOTPLUG_CPU,
> but the return value from coretemp_init() was left to indicate an
> error. This isn't correct, as the negative return value indicates to
> the module loader that initialization failed, which isn't intended
> here and results in dangling pointers.
> 
> Signed-off-by: Jan Beulich <jbeulich at novell.com>
> Cc: Chen Gong <gong.chen at linux.intel.com>
> 
Looks like my previous mail got lost or stuck in our e-mail system.
Trying again. Sorry if this message is received twice.

I have not seen an Acked-by for this set of patches, nor a Nack. Since 
(most of) the patches fix real bugs, I applied the ones which do into
my staging tree, and the others into my -next tree.

Guenter




More information about the lm-sensors mailing list