[lm-sensors] [PATCH v3] hwmon (coretemp): Fix build breakage if SMP is undefined

Ingo Molnar mingo at elte.hu
Tue Sep 28 10:27:29 CEST 2010


* Guenter Roeck <guenter.roeck at ericsson.com> wrote:

> Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced
> a build breakage if CONFIG_SMP is undefined. This commit
> fixes the problem.

This commit works around the problem in a hacky but not-so-ugly way.

( You might also want to include Linus's suggestion about how to fix it 
  for real in the future - so that we have at least some kind of record 
  of it. )

> Signed-off-by: Guenter Roeck <guenter.roeck at ericsson.com>
> Cc: Fenghua Yu <fenghua.yu at intel.com>

FYI, while i dont care about my Reported-by's but you lost a Reported-by 
tag here - you should be as careful about them as about your own 
signoffs.

> v2: Fix compile warning due to unused variable i if SMP is undefined 
> v3: include asm/smp.h instead of using ifdef CONFIG_SMP

I've started testing this fix - but i'd expect it to fix the problem - 
so consider it fixed unless i report back within a few hours that 
there's some breakage left.

Thanks,

	Ingo




More information about the lm-sensors mailing list