[lm-sensors] [PATCH v5 1/2] Use "request_muxed_region" in it87 watchdog drivers

Alan Cox alan at lxorguk.ukuu.org.uk
Wed Apr 13 11:29:47 CEST 2011


On Wed, 13 Apr 2011 09:03:00 +0200
Wim Van Sebroeck <wim at iguana.be> wrote:

> Hi Nat,
> 
> > +	(void) request_muxed_region(REG, 2, NAME);
> 
> Why do we need to typecast this? Can't we just use 
> +	request_muxed_region(REG, 2, NAME);

We really ought to use

	if ()

in theory the request can fail if someone has hogged the resource and not
muxed it. I'm not clear what the right thing to do in that case is -
given it should never happen I guess log an error and bail out but that's
a rather bigger change and perhaps should be a follow up patch ?




More information about the lm-sensors mailing list