[lm-sensors] [PATCH 2/2] hwmon: (lm85) Fix error paths in probe function

Jean Delvare khali at linux-fr.org
Fri Apr 29 10:25:08 CEST 2011


We must remove all files we created, even in error cases.

Fixes second part of kernel bug #34072:
https://bugzilla.kernel.org/show_bug.cgi?id=34072

Signed-off-by: Jean Delvare <khali at linux-fr.org>
Cc: Guenter Roeck <guenter.roeck at ericsson.com>
---
 drivers/hwmon/lm85.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.39-rc5.orig/drivers/hwmon/lm85.c	2011-04-29 09:50:12.000000000 +0200
+++ linux-2.6.39-rc5/drivers/hwmon/lm85.c	2011-04-29 10:12:56.000000000 +0200
@@ -1331,11 +1331,11 @@ static int lm85_probe(struct i2c_client
 	if (data->type != emc6d103s) {
 		err = sysfs_create_group(&client->dev.kobj, &lm85_group_minctl);
 		if (err)
-			goto err_kfree;
+			goto err_remove_files;
 		err = sysfs_create_group(&client->dev.kobj,
 					 &lm85_group_temp_off);
 		if (err)
-			goto err_kfree;
+			goto err_remove_files;
 	}
 
 	/* The ADT7463/68 have an optional VRM 10 mode where pin 21 is used


-- 
Jean Delvare




More information about the lm-sensors mailing list