[lm-sensors] [PATCH 2/4] hwmon: (f75375s) Use standard sysfs attribute names

Guenter Roeck guenter.roeck at ericsson.com
Mon Dec 12 17:40:37 CET 2011


On Sat, Dec 10, 2011 at 02:50:17PM -0500, Björn Gerhart wrote:
> 2011/12/8 Guenter Roeck <guenter.roeck at ericsson.com>:
> > The driver uses non-standard sysfs attribute names for maximum and target fan
> > speeds, even though standard attibute names for the same values do exist.
> > Replace non-standard attribute names with standard attribute names.
> > 
> > Cc: Riku Voipio <riku.voipio at iki.fi>
> > Signed-off-by: Guenter Roeck <guenter.roeck at ericsson.com>
> Reviewed-by: Bjoern Gerhart <oss at extracloud.de>

Hi Bjoern,

thanks a lot for the review of this and the other patches. I applied the series
to my -next tree.

I should add that this patch is special, since it changes sysfs attribute names.
I chose the direct method of changing the attribute names over providing both
the old and new names for a couple of releases, for a couple of reasons.
First, the "old" names are non-standard and thus not really useful for generic
applications, and second I did not find a reference that any of the non-standard
attributes is actually used. We'll find out if this will cause trouble.

Guenter




More information about the lm-sensors mailing list