[lm-sensors] [v3] Add support for the Philips SA56004 temperature sensor.

Jean Delvare khali at linux-fr.org
Thu Jul 7 13:28:17 CEST 2011


Hi Guenter,

On Sun, 26 Jun 2011 13:26:48 -0700, Guenter Roeck wrote:
> On Mon, Jun 06, 2011 at 10:40:45AM -0000, sdevrien at cisco.com wrote:
> > From: Stijn Devriendt <sdevrien at cisco.com>
> > 
> > Add support for the Philips SA56004, an LM86
> > compatible temperature sensor.
> > 
> > Changes since v2:
> > - Changed BUG_ON to WARN_ON
> > Changes since v1:
> > - Updated documentation
> > - Trace replaced by BUG_ON
> > - style updates
> > 
> > Signed-off-by: Stijn Devriendt <sdevrien at cisco.com>
> > Acked-by: Guenter Roeck <guenter.roeck at ericsson.com>
> > 
> I don't see a reason for holding this patch up further. Applied to -next.
> If you disagree, please speak up now or be silent forever.

Sorry for the long silence, I was frightened by the long discussion
back then - it's only today that I went through it to find most of it
was actually noise.

I don't have major objections to the patch, only a few things which I
think could be improved. So it's OK that your picked the patch as is,
I'll submit incremental patches for comments and review.

Stijn, please accept my apologies for being way less reactive than I
should have been, being the lm90 driver maintainer. And big thanks to
Guenter for backing me up.

-- 
Jean Delvare




More information about the lm-sensors mailing list