[lm-sensors] [PATCH] pmbus: Use long variables for register to data conversions
guenter.roeck at ericsson.com
Tue Jul 12 15:40:57 CEST 2011
On Tue, Jul 12, 2011 at 03:00:16AM -0400, Jean Delvare wrote:
> Hi Guenter,
> On Mon, 11 Jul 2011 12:04:24 -0700, Guenter Roeck wrote:
> > Using integer variable types for register to data conversions can cause
> > overflows especially for power calculations, which are in microwatt.
> > Use long variables instead.
> I have no objection, using longs for calculations certainly makes
> sense, however does it really help in practice? I thought that
> sizeof(int) == sizeof(long) for all architectures on Linux?
No ... for x86_64 long is 64 bit and int is 32 bit. I'll may have
to switch to "long long" at some point, though, or maybe s64.
Still hesitating to do that.
> > Signed-off-by: Guenter Roeck <guenter.roeck at ericsson.com>
> Either way:
> Acked-by: Jean Delvare <khali at linux-fr.org>
More information about the lm-sensors