[lm-sensors] [PATCH v6] drivers/hwmon NTC Thermistor Initial Support v6

[Guenter Roeck]

On Mon, Jun 13, 2011 at 03:15:59AM -0400, Donggeun Kim wrote:
> This patch adds support for NTC Thermistor series. In this release, the
> following thermistors are supported: NCP15WB473, NCP18WB473, NCP03WB473,
> and NCP15WL333. This driver is based on the datasheet of MURATA.
> 
> The driver in the patch does conversion from the raw ADC value
> (either voltage or resistence) to temperature. In order to use
> voltage values as input, the circuit schematics should be provided
> with the platform data. A compensation table for each type of thermistor
> is provided for the conversion.
> 
> Signed-off-by: Donggeun Kim <dg77.kim at samsung.com>
> Signed-off-by: MyungJoo Ham <myungjoo.kim at samsung.com>
> Signed-off-by: KyungMin Park <kyungmin.park at samsung.com>
> 
Hi folks,

Almost there.

[ ... ]

>  include/linux/ntc.h     |   53 ++++++

Please move this file to include/linux/platform_data/ntc.h.

One question, though: ntc.[ch] is quite high level and suggests a wider scope than just thermistors.
Would it make sense to use ntc_thermistor.[ch] instead ?

[ ... ]
> +       if ((data->mintemp != INT_MAX) || (data->maxtemp != INT_MIN)) {

The inner ( ) are unnecessary. Please remove.

Thanks,
Guenter